search

Flipkart / recyclerlistview

High performance listview for React Native and web!
Apache License 2.0
5.17k stars 421 forks source link

update prop-types in 3.0.6 release #641

Open bestrivens001 opened 2 years ago

bestrivens001 commented 2 years ago

Hi, @naqvitalha,

Issue Description

I noticed that a vulnerability is introduced in recyclerlistview@3.0.5: Vulnerability CVE-2020-15168 affects package node-fetch (versions:<2.6.1,>=3.0.0-beta.1 <3.0.0-beta.9): https://snyk.io/vuln/SNYK-JS-NODEFETCH-674311 The above vulnerable package is referenced by recyclerlistview@3.0.5 via: recyclerlistview@3.0.5 ➔ prop-types@15.5.8 ➔ fbjs@0.8.17 ➔ isomorphic-fetch@2.2.1 ➔ node-fetch@1.7.3

Since recyclerlistview@3.0.5 (17,255 downloads per week) is referenced by 22 downstream projects (e.g., react-native-calendar-picker 7.1.2 (latest version), @applicaster/zapp-react-native-tvos-cli-template 5.2.1 (latest version), @applicaster/zapp-react-native-tvos-ui-components 5.2.1 (latest version), react-native-calendar-strip 2.2.4 (latest version), @applicaster/horizontal-list-qb 2.0.4 (latest version)), the vulnerability CVE-2020-15168 can be propagated into these downstream projects and expose security threats to them via the following package dependency paths: (1)@symbolic/rn-lib@1.0.216 ➔ react-native-calendar-picker@7.1.2 ➔ recyclerlistview@3.0.5 ➔ prop-types@15.5.8 ➔ fbjs@0.8.17 ➔ isomorphic-fetch@2.2.1 ➔ node-fetch@1.7.3 (2)@admin-layout/timetracker-module-mobile@1.0.2-alpha.32 ➔ react-native-calendar-picker@7.1.2 ➔ recyclerlistview@3.0.5 ➔ prop-types@15.5.8 ➔ fbjs@0.8.17 ➔ isomorphic-fetch@2.2.1 ➔ node-fetch@1.7.3 ......

If recyclerlistview@3.0.* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Given the large number of downstream users, could you help update your package to remove the vulnerability from recyclerlistview@3.0.5 ?

Fixing suggestions

In recyclerlistview@3.0.6, maybe you can kindly try to perform the following upgrade(not crossing major version) : prop-types 15.5.8 ➔ 15.6.2;

Note: prop-types@15.6.2(>=15.6.2) doesn’t depend on node-fetch any more.

Thank you for your attention to this issue and welcome to share other ways to resolve the issue.^_^

quanghuynh1502 commented 1 year ago

@naqvitalha could you please take a look at this issue? It will help us a lot if we have a 3.0.6 version to fix this vulnerability.