Closed alantoa closed 1 year ago
@alantoa RLV has an API called applyWindowCorrection
that will allow you to handle all sorts of overlays or top padding. Have you looked into it? I don't think this PR is necessary.
https://github.com/Flipkart/recyclerlistview#applywindowcorrection-usage
@naqvitalha thanks for your review! ๐ I just checked it's my bad, I missed the docs, will close it! thanks again!
Description
Hi maintainers! ๐
this PR is for
FlashList
andrecyclerlistview
:1. if
contentContainerStyle
prop haspaddingTop
ormarginTop
, will get blank area when swiping up scrollview.Why
How
Test
Before
https://user-images.githubusercontent.com/37520667/186505022-218b66b2-dffc-460b-a44f-aa3c1502d165.mov
After
https://user-images.githubusercontent.com/37520667/186505208-eb048a8e-4c06-4251-8d22-0a1cd01a5646.mov
2.
renderScrollComponent
type warning.renderScrollComponent
(isexternalScrollView
on recyclerlistview) prop when we useReanimated
with FlashList.React.forwardRef
warp a component, while it doesn't affect usage, it's very annoying.so we can use
PropTypes.oneOfType
and add aPropTypes.object
type to avoid it.FYI: https://github.com/Flipkart/recyclerlistview/issues/233#issuecomment-499270292