Flipper-XFW / Xtreme-Firmware

The Dom amongst the Flipper Zero Firmware. Give your Flipper the power and freedom it is really craving. Let it show you its true form. Dont delay, switch to the one and only true Master today!
https://flipper-xtre.me
GNU General Public License v3.0
9.16k stars 650 forks source link

SubGHZ Repeater, Enable Sound Saved to Last Settings. #492

Closed LeeroysHub closed 6 months ago

LeeroysHub commented 6 months ago

What's new

SubGHZ Repeater. Re-transmit keys with no user interaction.


For the reviewer

subeax commented 6 months ago

@LeeroysHub "config -> Lock Keyboard" does not work:)

LeeroysHub commented 6 months ago

Thankyou!

Willy-JL commented 6 months ago

very well done!

i just fixed up a few bits of logic with the timer being allocated even if it already existed, changed it to a type once instead of timer periodic and stopping on first callback. also made it so variable items can be set as locked without passing the text again, fixes duplication. also the binraw index is already done with the enum, no need to keep a separate index :D. and the binraw/repeater logic could have been a bit cleaner in receiver enter, but the idea was absolutely correct.

i think i will do one last change, so that when i nrepeater mode the receiver view doesnt show received signals. its a bit confusing when you have signals, then switch to repeater and the signals are still there... no indication of repeater apart from led/sound, and you wont get new signals in the list.

other than that all looks great, thanks!

Willy-JL commented 6 months ago

changed it instead so that when enabling repeater it will check if history has signals and ask to discard or keep them

LeeroysHub commented 6 months ago

I have just changed the Repeater code to properly get the Key transmit Time. Te * Bits is the time for s key to transmit, not Te in Milliseconds. Small change, but want to make it all correct!