FlipperPA / wagtailcodeblock

StreamField code blocks for the Wagtail CMS with real-time PrismJS Syntax Highlighting.
BSD 3-Clause "New" or "Revised" License
156 stars 29 forks source link

Reduce block JS complexity #45

Open nickhendo opened 5 months ago

nickhendo commented 5 months ago

I have recently bumped into issues that look like #34. It looks like the dynamic loading of the JS libraries for specific languages seems to be the issue, although I couldn't quite find a way to reproduce the issue reliably though to properly track it down.

One thing though that does seem to reliably fix the issue, is switching to using prism-core in combination with the prism-autoloader as per the prism docs.

Fundamentally, this PR strips out most of that dynamic JS (not in the admin) and replaces with an onus to manually place a couple of template tags in the head and body of the HTML that would be using wagtailcodeblock. I don't personally see this as a large issue, seems standard behaviour from many other Django Applications.

I'm curious to get some input in making a change like this? I'm happy to work on making it backwards compatible so as not to break existing usage. Or something can perhaps be done with the versioning. Open to any thoughts on this.

Apologies if there's a better way to put this forward, I couldn't find any docs on contributing.