Combination flips - Githubissues

Flipping-Utilities / rl-plugin

BSD 2-Clause "Simplified" License

23 stars 13 forks source link

Combination flips #9

Closed zumaad closed 2 years ago

zumaad commented 2 years ago

This PR contains the code for supporting combination flips along with several QOL features + general refactoring of some stuff

QOL:

fixes the tooltip never going away bug
Makes rebuilds of the stat panel keep the same search query
Fixes the "members object" bug which occurs when a user logs into an f2p world and gets an offer filling for a members object
Prevents annoying rebuilds of the flipping panel when an item is highlighted
some other stuff I can't remember :/

Combination flips:

WILL DOCUMENT SOON (gotta go somewhere)

Screen Shot 2022-01-20 at 5 38 33 PM

TODO:

unit tests
documenting this pr

zumaad commented 2 years ago

Replace toAdjustedOfferEvent flow: To compute the profit, use qty - consumed on the item themselves, this way the profit calc only need to account for the items, and the items themselves will chose how much they consume from recipes / other events.

Don't fully understand this 🤔