search

FlipsideCrypto / badger

EVM primitive, protocol and app layer that exposes top-down management mechanisms for on-chain organizations. Badger is the key to the existing gates and locks within Web3.
https://www.trybadger.com/
MIT License
22 stars 1 forks source link

118 fix replay attacks #119

Closed nftchance closed 1 year ago

nftchance commented 1 year ago

This was the only critical issue flagged upon our first external contract audit. If a Badge was set with a signer and no payment token, then the signature could be re-used. While this model was acceptable for tokens that have payments (as it would revert, given they haven't been funded), free badges would not be okay.

Initially, this was okay because signatures were primarily intended to be used for individuals that have payments however there is a very, very specific use case where someone may have a signer on a free mint. So, this PR update to support that.

netlify[bot] commented 1 year ago

Deploy Preview for badger-frontend ready!

Name Link
Latest commit ccd9f0cd96f2550694c42f30842f0dc5081be307
Latest deploy log https://app.netlify.com/sites/badger-frontend/deploys/6363f6762cb760000944a579
Deploy Preview https://deploy-preview-119--badger-frontend.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

nftchance commented 1 year ago

I merged the changes to main from my large PR and resolved conflicts.

Beautiful thank you. I started and realized I was way out of my depth. -- Good to merge on my end :)