netlify[bot]
commented
2 years ago Deploy Preview for badger-frontend ready!
| Name | Link |
|---|---|
| Latest commit | f5a922bc61f744c545bfeb19d740718c8589f091 |
| Latest deploy log | https://app.netlify.com/sites/badger-frontend/deploys/63643d0de363c900089163bd |
| Deploy Preview | https://deploy-preview-131--badger-frontend.netlify.app/ |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
nftchance
This PR fixes the checksumming issues between the front end and backend. Decided against forcing their input to be altered into a check sum as it fundamentally does nothing different for us and could end up causing a little confusion (and saves us a lot of RPC calls). We do make sure the addresses are valid so as long as they are giving us valid addresses, they will be checksummed before being consumed by the backend.
We should not need check sums on the backend for now as the main issue was posting to the database with users/delegates that were not checksum and the indexer would create a new instance of the user with their check summed address. Once we get people interfacing with our backend then it may be worthwhile to handle it there anytime a new wallet model is created.
Also cleaned up when the validating error appear as well as disabling buttons if addresses are invalid.