FlipsideCrypto / badger

EVM primitive, protocol and app layer that exposes top-down management mechanisms for on-chain organizations. Badger is the key to the existing gates and locks within Web3.
https://www.trybadger.com/
MIT License
22 stars 1 forks source link

feat: badge archiving #154

Closed masonchain closed 1 year ago

masonchain commented 1 year ago

The current structure of the data fetching and mutating on the front end involves manipulating everything from the userData level from the data received from the initial fetch of the wallet/user.

The OrgData provider changes its value when the userdata changes. Currently, the fetch of a user does filter out held badges that are not active, but the organizations -> badges does not. I tried to address this on the backend but had 0 luck. However, when we do update the OrgData provider with the mutated or freshly fetched user data, we now filter out badges that are not active on the front end.

Somewhat of a band-aid solution but we already iterate through badges this way for non-owner accounts, so it is not a huge performance change to filter out this way as well.

netlify[bot] commented 1 year ago

Deploy Preview for badger-frontend ready!

Name Link
Latest commit d77b252eee976d0982cf0a6ff647ca2aced40f47
Latest deploy log https://app.netlify.com/sites/badger-frontend/deploys/6379383b324674000829dd73
Deploy Preview https://deploy-preview-154--badger-frontend.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

masonchain commented 1 year ago

Deleting this PR as most of this code has been deprecated with the refactor.