FlipsideCrypto / badger

EVM primitive, protocol and app layer that exposes top-down management mechanisms for on-chain organizations. Badger is the key to the existing gates and locks within Web3.
https://www.trybadger.com/
MIT License
22 stars 1 forks source link

fix: holder table multicall mint and revoking #211

Closed masonchain closed 1 year ago

masonchain commented 1 year ago

Improved UX, we determine what functions they need to run dynamically and if a multicall is necessary. The HolderTable.js kind of bent me over a barrel to be honest with you. I kind of hate the implementation but I beat my head against the wall for a while figuring out how to properly facilitate the 3 states we kind of have in it. Don't roast me but would love to get comments on it.

It does work though and aside from possibly a few bugs it looks and feels fantastic even if the code is a little shit.

Going to merge your most recent changes in here and get everything back up to date and cruising and then managers is following very closely behind.

github-actions[bot] commented 1 year ago

Slither report

Summary

github-advanced-security[bot] commented 1 year ago

You have successfully added a new Slither configuration .github/workflows/hardhat.js.yml:slither. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

nftchance commented 1 year ago

LGTM -- Merging this so that I can continue checking things off on the list while you get Managers.