search

Flix01 / imgui

Dear ImGui Addons Branch = plain unmodified dear imgui plus some extra addon.
https://github.com/Flix01/imgui/wiki/ImGui-Addons-Branch-Home
MIT License
396 stars 34 forks source link

Default size has no effect #33

Closed ibachar closed 6 years ago

ibachar commented 6 years ago

Hi,

The default size given to BeginDock is ignored / has no effect

Flix01 commented 6 years ago

True. Maybe it was intended to be the size of the window when in floating mode, but it doesn't seem to work :unamused: ...

I guess it should be better to remove the "default_size" argument completely and to force floating windows to keep the size they had while the user dragged them.

Users can resize them, but when a window is undocked it always starts with the same size it had when it was docked.

I think this behaviour is the best, but maybe when using imguidock at full screen some floating windows can be too large...

What do you think?

P.S. Although I've never tested them, now there should be flags to resize windows from any edge, as far as I've understood, so resizing windows can be easier.

I really think this is what users expect.

ibachar commented 6 years ago

Hm.. I'm not sure about the expected the behavior once undocked. Maybe some initial size upon first undock and then each window should remember its last undocked size?

Flix01 commented 6 years ago

I think I've fixed it.

Basically now undocked (= floating) windows have the initial size you specify. But if you don't pass their default_size, floating windows keep having their "dragging" size, until user manually resize them: from this point their default floating size is tracked and kept.

Hope it's OK.