search

Flix01 / imgui

Dear ImGui Addons Branch = plain unmodified dear imgui plus some extra addon.
https://github.com/Flix01/imgui/wiki/ImGui-Addons-Branch-Home
MIT License
395 stars 34 forks source link

imguitoolbar uses `void *` rather than `ImTextureID` #61

Closed tom-seddon closed 3 years ago

tom-seddon commented 3 years ago

Decided to make ImTextureID a uint32_t, as it's now an index into a table in my code, and encountered this:

https://github.com/Flix01/imgui/blob/0e047af0d7754b9d79c8fadb513aea5e0736c002/addons/imguitoolbar/imguitoolbar.h#L112

I'm in the middle of stuff right now, so no PR for now - please feel free to @ me if I forget - but I thought I should at least make a note. I can work around this for now by leaving ImTextureID as void * and casting to/from, so it's not a big problem.

Thanks,

--Tom

Flix01 commented 3 years ago

Thanks Tom for spotting this! I'm not sure why I left it as void*. Now it should be fixed. Closing this.