search

Flkalas / TwitterMediaAssist

Twitter Media Assist
https://addons.mozilla.org/en-US/firefox/addon/twitter-media-assist-ff
MIT License
83 stars 18 forks source link

3.0.0 fails for video on Firefox #5

Open rinikih opened 4 years ago

rinikih commented 4 years ago

Firefox version: 74 If in options/preferences only MP4 option is selected, then the video download fails.

Flkalas commented 4 years ago

ok i will check

Flkalas commented 4 years ago

it have seem to keep previous settings. please re-check and uncheck all checkboxes and rollback to your setting.

additionally, i will debug the option page to shows correct options.

if you solve problem by the above solution, please notice me. i will close this issue.

rinikih commented 4 years ago

I may not have explained the scenario properly. In the options page, if someone selects only " I want to save twitter video as" ONLY MP4 then it fails to download. if someone selects both "I want to save twitter video as" BOTH MP4 and TS, then it works and downloads as TS. Is this the intended behavior? I would have preferred to have twitter videos downloaded as MP4

Flkalas commented 4 years ago

oh. maybe you missread my answer. image

yesterday, I could reproduce your sympthm, but next I could not.

now is here more expains of my steps. First, I set options as first screenshot, It did not work with MP4 Video. ok. I see. And i diagnose why It not work. i recheck all options. image ok. it work with mp4 and ts next i uncheck all options. image expection is that would not work all type of video media. and it was. ok it is fine to me. now, i only check with mp4 video like first screenshot. then i stunned because of it work with only mp4 video option. image why this happened? i gauss that mp4 option maybe not set correctly by internal value but the option seem like checked. And i think that internal value of mp4 video option is corrected by unchecking and rechecking.

so would you please follow above actions and notify me?

and i will debug this option page error that force updating all option values correctly.

rinikih commented 4 years ago

I tried with the steps you mentioned. In my case, behaviour is different. 1st case: Only MP4, symptom reproduce, does not work 2nd case: Recheck all options, TS works, MP4 does not work 3rd case: Uncheck all options, nothing works

Does this help?