search

FloKaemmerer / dynamic-atlas

Searchable Path of Exile Atlas
MIT License
2 stars 1 forks source link

Fix filter drawer, eslint and removed prettier #42

Closed Blemming closed 1 year ago

Blemming commented 1 year ago

Didnt seperate commits very well, my bad. Fixed up the filter drawer so it uses the expansion panels a bit better Setup antfus eslint removed prettier

I have not linted the whole project yet as this would probably make for a huge PR to look through, but I'll fix up the formatting in files as I get to them.

FloKaemmerer commented 1 year ago

I will have a close look on the PR tomorrow (likely before the exilecon stream)

One thing I noticed wile scrolling through on mobile: The linter removes the {} on single line if. Maybe it's a java thing or the bit of clean code that stuck with me, I'd like to always use braces for if's. It's cleaner, more consistent and less error prone.

Blemming commented 1 year ago

Here you go, I overrode the rule and reapplied it to affected code :)