search

FloWuenne / scFunctions

Functions for single cell data analysis
23 stars 9 forks source link

Improvement #4

Closed GildasLepennetier closed 4 years ago

GildasLepennetier commented 4 years ago

Hi Florian

In the example "complete pipeline", there is a little problem with the dataset: the default value for the calculate_rrs function will not be found, and no value is actually set. Just modify the markdown file:

rrs_df <- calculate_rrs(metadata_sub, 
   binary_regulons = binary_regulons_trans, 
   cell_type_column = "cell_type")

I would actually remove the default in the function itself.

Otherwise, I think this is so far nice work, thanks

EDIT: I actually created a pull request.

FloWuenne commented 4 years ago

Thanks so much for the pull requests, Gildas! I have merged them to the main branch just now!

I will have to update the tutorial and add another tutorial for processing data from the new SCENICprotocol repo since the output is in a different format. I will do this once I find some time next week! Glad to know my functions helped!