Floating-Dartists / matomo-tracker

A fully cross-platform wrap of the Matomo tracking client for Flutter, using the Matomo API.
https://pub.dev/packages/matomo_tracker
MIT License
26 stars 28 forks source link

Adding `http.Client` argument to the MatomoDispatcher class #171

Closed tfreebern2 closed 2 months ago

tfreebern2 commented 2 months ago

httpClient is already an argument for the MatomoDispatcher class. This PR allows the developer to pass a custom http.Client through the initialize function.

TesteurManiak commented 2 months ago

Why would this be needed? MatomoDispatcher is not even exposed by the library.

tfreebern2 commented 2 months ago

Why would this be needed? MatomoDispatcher is not even exposed by the library.

The Matomo instance that my project is connected to requires certificate pinning. I've already created a fork that allows us to pass in a custom http.Client to pin the certificate required to hit the instance.