search

FloatingArrayDesign / MoorDyn

a lumped-mass mooring line model intended for coupling with floating structure codes
BSD 3-Clause "New" or "Revised" License
66 stars 37 forks source link

Updates from dev before new version release #140

Closed RyanDavies19 closed 9 months ago

RyanDavies19 commented 9 months ago

Some minor bug fixes to be added before the MoorDyn release:

  1. Fixed typos across a number of areas, including references to the documentation
  2. Fixed an error that prevented outputs from being written when writelog flag was disabled
  3. Added a missing axial drag coefficient that was also added to MoorDynF discussed in OpenFAST/openfast#1727
  4. Made the internal Eigen the default flag for compiling
  5. Fixed the catenary solver and added support for anchors and fairleads reversed
sanguinariojoe commented 9 months ago

The tests are failing.

Can this maybe wait for 2.2.2 release? (2.2.2 is also a patch release, it should not take long until we do that)

RyanDavies19 commented 9 months ago

@sanguinariojoe it can wait, as long as the patches come relatively soon. A few of the bug fixes are significant.

sanguinariojoe commented 9 months ago

@sanguinariojoe it can wait, as long as the patches come relatively soon. A few of the bug fixes are significant.

Otherwise you can fix the tests. I suppose it is not be a big deal actually

RyanDavies19 commented 9 months ago

@sanguinariojoe I updated all the tests to have a more accurate gravity value, the same as what is in MoorDynF and OpenFAST. All the tests pass so I am merging this into dev