FloatingArrayDesign / MoorDyn

a lumped-mass mooring line model intended for coupling with floating structure codes
BSD 3-Clause "New" or "Revised" License
66 stars 37 forks source link

Adjustments to Dynamic relaxation #164

Closed RyanDavies19 closed 9 months ago

RyanDavies19 commented 9 months ago

Resolves #160

This PR removes the double counting of line weight and changes the dynamic relaxation routine to match the now fixed fortran code. The changes to the dynamic relaxation routine are as follows:

RyanDavies19 commented 9 months ago

Not sure why pendulum is failing, all looks fine on my end. Will dig into this tomorrow.

sanguinariojoe commented 9 months ago

Not sure why pendulum is failing, all looks fine on my end. Will dig into this tomorrow.

If you set the error tolerance to 2.5% it works (line 150):

CHECK_VALUE("T", t_peaks[i], i * 0.5 * T, 0.025 * T, t_peaks[i]);

Not a big deal I suppose

RyanDavies19 commented 9 months ago

@sanguinariojoe I adjusted to 0.025. I think it's fine given how things are behaving.