search

FloatingArrayDesign / MoorDyn

a lumped-mass mooring line model intended for coupling with floating structure codes
BSD 3-Clause "New" or "Revised" License
64 stars 37 forks source link

Give back the same values by the output channels #210

Closed sanguinariojoe closed 1 month ago

sanguinariojoe commented 2 months ago

This should fix the problem found by @RyanDavies19 at https://github.com/FloatingArrayDesign/MoorDyn/pull/202

The API still works the new way though.

As I suppose it can be appreciated, the former way is quite inconsistent, at least with respect the fairlead and the anchor. Maybe it would be good to take the axial damping out to it own API method (MoorDyn_GetLineNodeTenD() and moordyn::Line::getNodeTenD())

sanguinariojoe commented 1 month ago

Oki, tomorrow I will try to do that

On Thu, 9 May 2024, 17:39 RyanDavies19, @.***> wrote:

@.**** commented on this pull request.

In source/Line.cpp https://github.com/FloatingArrayDesign/MoorDyn/pull/210#discussion_r1595623946 :

@@ -531,12 +531,15 @@ Line::GetLineOutput(OutChanProps outChan) return rd[outChan.NodeID][1]; else if (outChan.QType == VelZ) return rd[outChan.NodeID][2];

  • else if (outChan.QType == Ten)
  • return getNodeTen(outChan.NodeID).norm();
  • else if (outChan.QType == Ten) {
  • if ((outChan.NodeID == 0) || (outChan.NodeID == N))
  • return getNodeForce(outChan.NodeID).norm();
  • return (0.5 * (T[outChan.NodeID] + T[outChan.NodeID - 1])).norm();

I think here for internal nodes we should return the wall tension using Line::getNodeTen(outChan.NodeID).norm(). This would keep output channels consistent with what is done in MDF, where the subroutine GetLineTen is returned for the "Ten" output channel: https://github.com/OpenFAST/openfast/blob/6a7a543790f3cad4a65b87242a619ac5b34b4c0f/modules/moordyn/src/MoorDyn_IO.f90#L1885

— Reply to this email directly, view it on GitHub https://github.com/FloatingArrayDesign/MoorDyn/pull/210#pullrequestreview-2048250048, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMXKKGD2K2DE6BUCLJ7WXDZBOKDVAVCNFSM6AAAAABHOEXIGGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBYGI2TAMBUHA . You are receiving this because you authored the thread.Message ID: @.***>

RyanDavies19 commented 1 month ago

@sanguinariojoe Thanks for making those fixes, all looks good compared to MDF now so I will merge.

Figure_3

Figure from the same test case mentioned in #202