search

FloatingArrayDesign / MoorDyn

a lumped-mass mooring line model intended for coupling with floating structure codes
https://moordyn.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
71 stars 40 forks source link

Update MD-F comparison to point to OpenFAST/dev #232

Open RyanDavies19 opened 3 months ago

RyanDavies19 commented 3 months ago

OpenFAST/dev now has a more robust suite of regression tests that should capture most of MoorDyn's capabilities including 6 DOF dynamics and cable. Our checking of things should be against the dev branch for the time being until it gets merged into OpenFAST/main. This might break the MD-F tests for #231.

Corresponding OpenFAST PR: https://github.com/OpenFAST/openfast/pull/2294

RyanDavies19 commented 3 months ago

Consider this in progress for now, I will try to address the failing tests Monday after the long weekend for the 4th of July. Will also try to get GH artifacts going so we can download plots of the failed tests if/when they fail

sanguinariojoe commented 3 months ago

OK, I am just waiting until you give me a heads up

sanguinariojoe commented 3 months ago

BTW, @RyanDavies19 please amend the commit and set a "test: " prefix (see https://github.com/FloatingArrayDesign/MoorDyn/issues/230)

RyanDavies19 commented 2 months ago

@sanguinariojoe okay we now have test artifacts with plots of channels and error thresholds so we can see what is broken. As for why those tests don't line up, that will take further investigation. In the mean-time this is ready to be merged.

RyanDavies19 commented 1 month ago

@AlexWKinley and @sanguinariojoe, not sure if either of you have a rush for exact kinematics but what's in MD-C at the moment isn't entirely right. Once https://github.com/OpenFAST/openfast/pull/2334 is merged, a corresponding update needs to be made on the MD-C side to the body and rod kinematics (adding centripetal moments in addition to the centripetal forces from #231). That will be a more correct approach to 6 DOF kinematics.

After that is done, tests here should agree with the exception of md_lineFail. md_lineFail will be fixed when I get around to updating our line failures

sanguinariojoe commented 1 month ago

Everything good on my end, no need to rush. I am busy with some other interesting stuff for MoorDyn! :-p

AlexWKinley commented 1 month ago

Similarly, no rush from my end. (Although I suspect that exactly correct kinematics in 6dof are still more complicated than any of our numerical models have accounted for). I'm busy with other work for the moment. I do super appreciate the work that's been happening here in terms of checking agreement between the two MoorDyn implementations.