search

FloatingArrayDesign / MoorDyn

a lumped-mass mooring line model intended for coupling with floating structure codes
https://moordyn.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
74 stars 42 forks source link

Fixed rod hydrostatics bug #237

Closed RyanDavies19 closed 3 months ago

RyanDavies19 commented 4 months ago

Changed the rod submergence code to match what is in MD-F, which has been verified with other codes. The submergence scalar, VOF0, was being incorrectly calculating causing rods to have less buoyancy than they should. Both MD-F and MD-C now match on the heave decay test for the case in #236.

Resolves #236

RyanDavies19 commented 3 months ago

Merging this evening if there are no objections

sanguinariojoe commented 3 months ago

Hey! I am on vacations. Feel free to merge. It is the dev branch, right?

On Mon, 29 Jul 2024, 17:28 RyanDavies19, @.***> wrote:

Merging this evening if there are no objections

— Reply to this email directly, view it on GitHub https://github.com/FloatingArrayDesign/MoorDyn/pull/237#issuecomment-2256241405, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMXKKE4DEWNEC4BGBPH7XTZOZNQTAVCNFSM6AAAAABLRH2BSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGI2DCNBQGU . You are receiving this because you are subscribed to this thread.Message ID: @.***>

RyanDavies19 commented 3 months ago

@sanguinariojoe Yep, on the dev branch. Everything behaves as it should and tests still pass. Merging