search

FloatingOriginInteractive / BalsaIssues

The official issue tracker for Balsa Model Flight Simulator
6 stars 0 forks source link

Inconsistent wing property nomenclature #42

Open Ranganrs1 opened 3 years ago

Ranganrs1 commented 3 years ago

Describe the bug Different wing parts use different names for wing properties

To Reproduce Steps to reproduce the behavior:

  1. Place down different wing parts
  2. Right-click on them to see that they have different names for the same properties.

Here's all the properties, as written and in the order given in-game, for each part, as of the current version:

AF-4 Modwing: "span" "chord" "Thickness" "Horz. Taper" "taperVert" "sweep" "curve" AF-2 Modwing: "span" "chord" "thickness" "sweep" "curve" AF-5 Modwing: "span" "chord" "Thickness" "Horz. Taper" "taperVert" "sweep" "curve" AF-3 Modwing: "span" "chord" "thickness" "taperHorz" "taperVert" "sweep" "curve" AF-1 Modwing: "span" "chord" "thickness" "taperHorz" "taperVert" "sweep" "curve" AF-M0 Modwing: "Span" "Sweep" "Chord" "Horz. Taper" "Thickness" "Vert. Taper" Weevot Z-2 Control Surface: "Sweep" "span" "Chord" "Horz. Taper" "Vert. Taper" "Thickness" "Skew"

The names are in a different order, capitalization is inconsistent, and taper properties are inconsistent.

Expected behavior Properties should be in a consistent order between all parts, and the same property should be referred to by only one term, such as Horz. Taper, not Horz. Taper and taperHorz. Capitalization should be consistent across all terms, either all lowercase or all capitalized.

Screenshots AF1 AFM0

Desktop (please complete the following information):

Additional context One solution here would be to use some sort of localization key system (i.e. each part references a table of what it should call a certain property), so that not only would names be consistent between parts and developers, but translation would be made easier than with hardcoded names for each property. The properties should also have a standardized order so that users know where to look for a certain property.

PsykomantaBrain commented 3 years ago

Those are the internal names for the morph tweaks... I remember using the localization system to tidy them up at one point... seems they have reverted somehow.