search

Floby / node-libspotify

Node bindings for the libspotify C library
projects.flo.by/node-libspotify/
103 stars 66 forks source link

starred playlist support #30

Open LinusU opened 10 years ago

LinusU commented 10 years ago

Support for getting the special "starred" playlist, session.getStarred().

LinusU commented 10 years ago

Just saw that you made some slight refactoring to the tests, will updated and push within 5 minutes :)

LinusU commented 10 years ago

Oh fuck, I really screwed this up, will try to rebase on your master...

LinusU commented 10 years ago

Success! I've run all the tests locally and it should be good to merge.

Floby commented 10 years ago

Looks good to me. I'm wondering if it's a good testing practice to assume the currently logged in user will have starred at least one track.

LinusU commented 10 years ago

True, do you want me to remove that line?

Floby commented 10 years ago

No, that's a good test. Maybe we should star a track before that.

On 26 September 2013 11:33, Linus Unnebäck notifications@github.com wrote:

True, do you want me to remove that line?

— Reply to this email directly or view it on GitHubhttps://github.com/Floby/node-libspotify/pull/30#issuecomment-25154573 .