search

Floby / node-libspotify

Node bindings for the libspotify C library
projects.flo.by/node-libspotify/
102 stars 66 forks source link

[WIP] Supports Node 0.12+ by using nan. #46

Closed tcr closed 8 years ago

tcr commented 9 years ago

This PR adds support for Node 0.12+ and io.js by switching to building with nan.

This PR is still failing three tests, and I was accidentally working off of an old commit so it requires a slightly more careful review. (Sorry.)

I'll hopefully fix this in the next week and have it be mergable, though I would love any offer of help or time people have.

tcr commented 9 years ago

Looks like @IainCole has been maintaining the most active recent branch, so I'll summon you if you have input.

Floby commented 9 years ago

This looks interesting. I do have to make time and merde Ian's branches Le 16 mars 2015 05:51, "Tim Cameron Ryan" notifications@github.com a écrit :

Looks like @IainCole https://github.com/IainCole has been maintaining the most active recent branch.

— Reply to this email directly or view it on GitHub https://github.com/Floby/node-libspotify/pull/46#issuecomment-81412349.

19h commented 9 years ago

Thanks @tcr!

I was already in the process of porting to nan a month ago, but stumbled over some issues. Great to see progress here!