search

Floby / node-libspotify

Node bindings for the libspotify C library
projects.flo.by/node-libspotify/
102 stars 66 forks source link

jslint / whitespace fixes #9

Closed ronaldevers closed 11 years ago

ronaldevers commented 11 years ago

did some cleaning up, not too sure about that last commit and didnt test -> going to bed now since i'm practically already :sleeping:

thanks for this project, enjoying it a lot

working on hubot integration by the way

Floby commented 11 years ago

looks good to me. I'll run npm test and merge if they pass.

seeing there are some more people than just me contributing to this project I'm gonna add some lint and style guidelines. I'll try and open issues in advance so that people wanting to contribute can find what to start with. Le 30 mai 2013 01:16, "Ronald Evers" notifications@github.com a écrit :

did some cleaning up, not too sure about that last commit and didnt test -> going to bed now since i'm practically already [image: :sleeping:]

thanks for this project, enjoying it a lot

working on hubot integration by the way

You can merge this Pull Request by running

git pull https://github.com/ronaldevers/node-libspotify master

Or view, comment on, or merge it at:

https://github.com/Floby/node-libspotify/pull/9 Commit Summary

  • tweaking the readme
  • cleanup, jslint, whitespace
  • remove unused var and fixup search.execute

File Changes

  • M README.mdhttps://github.com/Floby/node-libspotify/pull/9/files#diff-0(13)
  • M lib/Album.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-1(4)
  • M lib/Artist.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-2(3)
  • M lib/Player.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-3(15)
  • M lib/Playlist.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-4(69)
  • M lib/PlaylistContainer.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-5(18)
  • M lib/Search.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-6(11)
  • M lib/Session.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-7(18)
  • M lib/SpObject.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-8(103)
  • M lib/Track.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-9(2)
  • M scripts/travis-install.shhttps://github.com/Floby/node-libspotify/pull/9/files#diff-10(4)
  • M src/playlistcallbacks.cchttps://github.com/Floby/node-libspotify/pull/9/files#diff-11(10)
  • M test/test-000-a-check.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-12(2)
  • M test/test-000-config.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-13(4)
  • M test/test-010-session01-instance.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-14(7)
  • M test/test-010-session02-login.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-15(6)
  • M test/test-020-search-01-create.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-16(4)
  • M test/test-020-search-02-process.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-17(5)
  • M test/test-030-track.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-18(6)
  • M test/test-031-album.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-19(11)
  • M test/test-050-player00-track.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-20(8)
  • M test/test-050-player01-end-of-track.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-21(4)
  • M test/test-060-link.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-22(11)
  • M test/test-070-backoff-ready.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-23(6)
  • M test/test-080-playlist.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-24(19)
  • M test/test-999-cleanup.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-25(5)
  • M test/util.jshttps://github.com/Floby/node-libspotify/pull/9/files#diff-26(11)

Patch Links:

Floby commented 11 years ago

Tests are passing, except the usual session bugs which are mine. Merging & closing.