FloeDesignTechnologies / ansible-nginx-drupal

Ansible role to configure Nginx for running Drupal using perusio's configuration
Apache License 2.0
22 stars 12 forks source link

Configurable nginx user and Boost support #8

Closed dmajorel closed 10 years ago

dmajorel commented 10 years ago

A new nginx_drupal_user variable has been added to configure the user directive in nginx.conf. Default value is www-data.

Boost configuration is now enabled when setting nginx_drupal_use_boost to true.

pbuyle commented 10 years ago

Boost and non-boost configuration are not that much different. Comparing the drupal.j2 and drupal_boost.j2, there is only 3 different blocks. The first one are the header used for "Advanced Aggregation module JS". The second block is the @cache definition and usage. And the third one is Boost stat support.

Instead of using two files nearly identical files, I would prefer a single drupal.j2 file with a few conditional blocks. This would ensure configuration change applicable to boost and non-boost configurations will always be shared.

dmajorel commented 10 years ago

Will resubmit later.

pbuyle commented 10 years ago

That would be great. Boost is a well known solution. Support for it would be a great addition. @dmajorel Feel free to re-open this pull request whenever you have something, even unfinished.I cannot commit to work on this, but do not hesitate to ask question, request review of even suggest alternatives.