search

FloeDesignTechnologies / phpcs-security-audit

phpcs-security-audit is a set of PHP_CodeSniffer rules that finds vulnerabilities and weaknesses related to security in PHP code
GNU General Public License v3.0
712 stars 85 forks source link

Travis: fix the build #77

Open jrfnl opened 4 years ago

jrfnl commented 4 years ago

The Travis docs say that $TRAVIS_BUILD_STAGE_NAME is in "proper case" form:

TRAVIS_BUILD_STAGE_NAME: The build stage in capitalized form, e.g. Test or Deploy. If a build does not use build stages, this variable is empty ("").

However, it looks like they made an (undocumented) change (probably a bug in their script handling) which means that the $TRAVIS_BUILD_STAGE_NAME name is now in the case as given, which in this case is lowercase.

This means that some of the comparisons are failing and the wrong things are executed for certain builds.

As I expect this to be a bug in Travis, I'm not changing the case for the comparisons at this time. Instead I'm fixing this by inline fixing the case of the variable for the comparisons.

Refs:

jrfnl commented 4 years ago

Anything I can do to move this PR forward ?