search

FlominatorTM / wikiblame

http://wikipedia.ramselehof.de/wikiblame.php
GNU General Public License v3.0
54 stars 13 forks source link

cURL implementation for requests #17

Closed vlakoff closed 6 years ago

vlakoff commented 6 years ago

Follow-up to #15.

Maybe #16 should be merged first, then I could rebase this one for better clarity.

vlakoff commented 6 years ago

By the way, I just found out composer/ca-bundle. It's a one-file class that allows robuster CA detection.

Though, using an embedded CA as I'm doing in this PR should be good enough.

vlakoff commented 6 years ago

Rebased :)

vlakoff commented 6 years ago

I just noticed, in /shared_inc/wiki_functions.inc.php, the function post_request and its comment "//todo: can be replaced by the solutin from purge() below", which is a bit inexact now, as purge just calls the curl_request function I have added.

This legacy post_request function seems unused, maybe you could simply remove it.

vlakoff commented 6 years ago

Same goes for get_request which is also unused and could be removed as well.

edit: noticed a remaining use of get_request. It will just submit a PR with the changes I have in mind.