search

FlominatorTM / wikiblame

http://wikipedia.ramselehof.de/wikiblame.php
GNU General Public License v3.0
54 stars 13 forks source link

Add the link to the diff again in the end in bigger and bold characters #6

Closed tbertels closed 7 years ago

tbertels commented 8 years ago

The use of WikiBlame is to find the diff showing where the searched changes happened. However, currently that diff link isn't any more highlighted than the other links and is difficult to locate in day to day use. New users even don't find that link sometimes or it may take them some time (see here).

So it would very useful to add again that link after the end of the search with something like Link to diff (in bigger font).

FlominatorTM commented 7 years ago

Congratulations for writing the description the way you did and not the others. That made pop up the solution I just implemented. Please tell me if is ok like this and re-open this issue if not.

FlominatorTM commented 7 years ago

Might be interesting for @he7d3r as well

tbertels commented 7 years ago

Thank you for the fix! It looks great, however I really think you should make the text in bold, I actually didn't notice it at first. In case you prefer not to do so, can we do it in the translations, and is it with <b></b>?

tbertels commented 7 years ago

It works fine with <b></b> by the way, see the French translation. A longer text than "here" like that one makes it also easier to click on the link, and it's better in general to give links a name with the meaning of what they do, like in the wiki.

FlominatorTM commented 7 years ago

The idea of having "uncontrolled html tags" in the translation worries me a little. Maybe I should make the link bold myself and label it "see change found" or something?

tbertels commented 7 years ago

Yes, it would be a great idea, as a longer bold text is easier to see and click.

FlominatorTM commented 7 years ago

@waldyrious fixed it with https://github.com/FlominatorTM/wikiblame/pull/10

I assume, it's now ok like this?