Floobits / floobits-atom

Remote pair programming plugin for Atom.
Apache License 2.0
235 stars 18 forks source link

Deprecated selector in `floobits/styles/floobits.atom-text-editor.less` #144

Open CodeBrotha opened 7 years ago

CodeBrotha commented 7 years ago

In floobits/styles/floobits.atom-text-editor.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

ggreer commented 7 years ago

I'm pretty sure this is because of the @import "ui-variables"; line. Once Atom removes their own deprecated settings, the warning should go away.

JasonSooter commented 7 years ago

+1 Noted

mingsai commented 7 years ago

I've put in a pull request that resolves this issue.