Floobits / floobits-emacs

Floobits plugin for emacs
Apache License 2.0
152 stars 14 forks source link

Stop Fucking Up Mark #6

Closed kans closed 11 years ago

kans commented 11 years ago

-someone wished for this.

zane commented 11 years ago

I was the one that wished for this. For context, I seem to be unable to use marks while floobits is active.

kans commented 11 years ago

I can't reproduce this bug on Aquamacs 23.4. What os and emacs are you on? Also, what other plugins are you running?

zane commented 11 years ago

GNU Emacs 24.3.50.1. Like anyone I have a pile of customizations in my init.el.

jcinnamond commented 11 years ago

I can reproduce this bug on GNU Emacs 24.3.1 on osx. I moved my config out of the way and went with a vanilla setup + melpa + flootbits so I'm pretty confident that (a) it's easy to reproduce and (b) it isn't interaction with another package causing this.

ggreer commented 11 years ago

OK, try it out now. We should do a better job of not breaking things. Apparently save-excursion wasn't enough.

kans commented 11 years ago

see https://github.com/Floobits/floobits-emacs/commit/b83bccdc3a15ac1b1961dbf7c12b6be4ca494d90

jcinnamond commented 11 years ago

Seems to work. Good job guys.

ggreer commented 11 years ago

Cool. Closing...