Floobits / floobits-sublime

Floobits real-time collaboration plugin for Sublime Text 2 and 3
Apache License 2.0
294 stars 31 forks source link

Not synchronising deletes #181

Closed CMCDragonkai closed 10 years ago

CMCDragonkai commented 10 years ago

When I delete a file or a folder on my workspace inside Sublime, this doesn't propagate to the web editor.

ggreer commented 10 years ago

This is because Sublime Text doesn't let plugins bind to delete events. You can remove files from the workspace by right-clicking on them in the sidebar, then going to Floobits → Remove from Workspace.

Sorry we can't make it any easier than that. :(

CMCDragonkai commented 10 years ago

What about a file watcher like facebooks watcher tool?

kans commented 10 years ago

A large amount of this codebase is shared between ST, Vim, and Emacs. File watching isn't part of the python stdlib and there is no portable way to ship pure python that does this. Binding the native libraries is not an option- particularly on Linux where every distro is expected to have its own package manager install everything (a ST3 plugin steps outside this system).

We tried exactly this for python's SSL module for linux (which is missing in ST!!!?!?) and it was an enormous burden that never worked well. We shipped a dozen or so SOs compiled against just as many versions of openssl. We ended up replacing that code by spawning a system python to use as a proxy.

We could poll the filesystem, but this is too inefficient in practice. If you have another idea, I'm all ears.

CMCDragonkai commented 10 years ago

This was the one I was referring to: https://github.com/facebook/watchman But yes it doesn't support Windows at the moment.

But this would be an important feature, otherwise workspaces eventually get out of sync.

What if you periodically polled the filesystem?