[Low-quality PR] Fix user flow for "create new workspace" with bad characters

Floobits / floobits-sublime

Floobits real-time collaboration plugin for Sublime Text 2 and 3

Apache License 2.0

294 stars 31 forks source link

[Low-quality PR] Fix user flow for "create new workspace" with bad characters #212

Closed shawndrost closed 9 years ago

shawndrost commented 9 years ago

The code path I moved in this commit will not be reached AFAICT -- the server returns a 400 and reaches the exception path instead. I've moved it and probably created other problems. However, I can promise that currently, creating a repo with a / in it results in the error message "400 BAD REQUEST" and not "don't use that character".

(I haven't tested this... sorry! Hope this PR is useful anyway.)

btipling commented 9 years ago

Thank you! We'll check it out. :boom: :heart:

btipling commented 9 years ago

So it shouldn't reach an exception path since we catch the urllib HTTPError and then set state accordingly in the APIResponse. We'll have to test this.

ggreer commented 9 years ago

Sorry this took so long. We've found the root cause of these issues and fixed it in the latest release. Thanks for telling us about it.