search

Floobits / flootty

A collaborative terminal.
Apache License 2.0
175 stars 25 forks source link

unable to hit <return> in remote flootty terminal #29

Closed deanmalmgren closed 10 years ago

deanmalmgren commented 10 years ago

I'm unable to hit return to trigger a command in a remote flootty session that is hosted on @bo-peng's laptop. When I host the flootty session, she is unable to hit return too.

I'm not sure if this is related, but after exiting the flootty session, my prompt gets royally messed up:

screen shot 2014-05-07 at 10 43 37 am

source ~/.bashrc does not fix the problem and I end up just having to close that terminal window.

btipling commented 10 years ago

You'll need to start flootty with --unsafe to make it possible for others to hit return, this is a security feature. Try flootty --help to look at a complete list of options.

deanmalmgren commented 10 years ago

@ggreer and I discussed this a bit on IRC and we got distracted by other things. To capture the essence of the conversation, it seems like we could address this by either:

  1. printing a message out for users when they start/join a flootty session that alerts them that they will be unable to run commands without the --unsafe option or
  2. give users with edit/admin permissions on the workspace the ability to run commands, regardless of whether the --unsafe option is specified (the idea being that these users are trusted anyway).

I'm good with either option.

ggreer commented 10 years ago

We added a message mentioning safe/unsafe mode when you start flootty.

The terminal reset thing is another matter. We try to get out of raw mode on exit, but apparently we're not covering every possibility.