search

Flood-UI / flood

A web UI for rTorrent, qBittorrent and Transmission with a Node.js backend and React frontend. Migrate to v4: https://github.com/jesec/flood/wiki/Migrate-from-older-versions-of-Flood.
https://flood.js.org
GNU General Public License v3.0
1.82k stars 173 forks source link

Ignoring tracker errors and viewing tracker status #486

Open Avamander opened 6 years ago

Avamander commented 6 years ago

Is there a way to make Flood ignore tracker errors, it's so common for some tracker to be down and then everything just has a red bar making it rather difficult to have a good overview. It's also rather difficult to find out an individual tracker's status, would it be possible to display that too?

sachaw commented 6 years ago

+1 for better error display

jfurrow commented 6 years ago

I'll consider this.

Where in the UI would you like to find an individual tracker's status?

sachaw commented 6 years ago

I think on the tracker page, possibly highlight the one with an error and either have an arrow to expand the error, have inline or newline right below it

Avamander commented 6 years ago

@jfurrow I agree with @sachaw, but will you consider both changes? Because pretty much every torrent of mine is painted red at the moment :D

randomnonsense commented 6 years ago

@jfurrow Hiding offline trackers and hiding actual tracker errors are two separate things. Perhaps the best way to go would be marking offline trackers "hidden" or whatever of the sort.

Trackers report errors to clients for a very good reason. This must not be hidden. Note that on private trackers users are sometimes expected to stay in line with their client behaviours and take responsibility for them.

sachaw commented 6 years ago

I thhink optimising for readability of the list: Grey if stopped Green if seeding Black if done and not seeding If there are errors, still default to whatever state it would be in otherwise e.g. one tracker failed but is still seeding, it should be green.

Possibly just leave the exclamation mark where it is so you can still see what torrents have issues.

randomnonsense commented 6 years ago

What @sachaw proposes makes sense. Edit: default color if a tracker is offline or timed out. NOT if there is an actual tracker error. As said above, tracker errors should be obvious. If there is an error, a well configured tracker wants to tell something apparently important to the client. This cannot simply be ignored. This makes most sense in regard to private trackers, not necessarily public ones.

Since we are at this, @jfurrow could also consider breaking current "Percent complete" into two separate columns, "Status" and "Percent complete". This should allow easy sorting via status within particular category simply by clicking column headers.

Also a better readable "percent complete" bar would be welcome, e.g. something with borders easily visible (so it can be seen easily how much is done), for example:

bar

sachaw commented 6 years ago

sorry @randomnonsense That's what I meant.

jfurrow commented 6 years ago

I agree with what @sachaw suggested — leaving the colors of the torrent alone, but displaying the exclamation icon when an error is detected.

Discerning between tracker errors and timeouts is not possible (at least not via rtorrent), as far as I know. Flood considers a torrent to have an error if the message property on the tracker contains a string. If it does, then Flood determines the torrent is in the error state (this is consistent with ruTorrent's behavior, as far as I know). I don't think there's any way to tell if the tracker is timing out, or in some other state.

@randomnonsense I'd like to find another solution for better legibility in the progress bar. Maybe opening a separate ticket for that would help facilitate further discussion on a better design.

sachaw commented 6 years ago

New progress bar issue #500

Avamander commented 6 years ago

I'm mainly wanting the option to ignore trackers because public trackers are god awful, they randomly go down, they give funky errors etc. so my list of Linux isos is basically all red because even with two online trackers one is always down. It's seriously hindering the ability of having a good overview of what's downloading/active/actually errored (missing files etc.).

randomnonsense commented 6 years ago

@jfurrow can you make this user selectable? E.g. "Hide tracker errors", as a tick-box in Settings. Or since rtorrent (and hence flood) can read private flags, you could go for "Hide tracker errors on non-private torrents". This way anybody can choose whatever they want.

lflare commented 6 years ago

I'm going to casually bump this because I think this is kind of a pressing issue when trying to view individual torrent statuses. As I speak, my entire setup is filled with red torrents that are very clearly downloading and not actually fatal unlike the impression that the red error is giving.