Flood-UI / flood

A web UI for rTorrent, qBittorrent and Transmission with a Node.js backend and React frontend. Migrate to v4: https://github.com/jesec/flood/wiki/Migrate-from-older-versions-of-Flood.
https://flood.js.org
GNU General Public License v3.0
1.81k stars 173 forks source link

Unable to add torrent files larger than 1.5 MB #54

Open zp opened 8 years ago

zp commented 8 years ago

Running Flood from commit 9461817

Whenever I attempt to add a large torrent file (1.5 MB or larger), the UI returns an error 500.

POST http://ip:port/api/client/add-files 500 (Internal Server Error)  xhr.js:161
    xhrAdapter @ xhr.js:161  (webpack:///./~/axios/lib/adapters/xhr.js)
    executor @ dispatchRequest.js:27  (webpack:///./~/axios/lib/core/dispatchRequest.js)
    dispatchRequest @ dispatchRequest.js:11  (webpack:///./~/axios/lib/core/dispatchRequest.js)

I'm able to add multiple < 1.5 MB torrent files at the same time (that go over 1.5 MB total size), so it seems like it's isolated to a single-file size limit instead of a total size limit, at least according to my brief testing.

Also seems to work fine when adding large torrent files from directly from a URL.

jfurrow commented 8 years ago

This is definitely a bug. I think it's a problem with the way I'm sending the base64 encoded torrent to rTorrent via node's net module. Do you happen to have a legal torrent that is over 1.5 mb that I can experiment with? If not, I'll track one down. I've just been trying to send large jpegs to expose the bug.

Decondelite commented 7 years ago

I'm getting this issue too and posting here in this ticket to confirm. My server's config: OS : Debian 8 Java : jdk1.8.0_112 Libtorrent : libtorrent-0.13.6 rtorrent : rtorrent-0.9.6 Flood : version available on 13/02/17

jfurrow commented 7 years ago

Thanks @Decondelite.

If anyone has any idea how this limit can be altered, I'd be grateful. I haven't spent a ton of time debugging this, unfortunately, but will get back to it ASAP.

HLFH commented 7 years ago

@jfurrow

Just a suggestion that works on Transmission for torrent file size limit.

With Nginx:

client_max_body_size 20M;

Or with Apache:

<Location />
   LimitRequestBody 20971520
</Location>
nVitius commented 7 years ago

There's a setting to increase the max size for xmlrpc requests: https://github.com/rakshasa/rtorrent/blob/master/src/command_network.cc#L303

Might be worth looking into.

joydashy commented 6 years ago

Setting "network.xmlrpc.size_limit.set = 4M" in my .rtorrent.rc fixed this for me, thanks!

noraj commented 6 years ago

Flood is using xmlrpc interface to control rTorrent, so the maximum file site on xmlrpc can be change is larger files need to be transferred as @nVitius and @joydashy said.

@jfurrow Does flood can modify this kind of settings and remember it after a rTorrent restart (thats means storing those settings, checking if they are set when flood start, and check rTorrent status to send them every time rTorrent restart or wrinting in .rtorrent.rc)?

bootldrDNB commented 6 years ago

Hm, this is still a problem for me, even after setting network.xmlrpc.size_limit.set = 4M in rtorrent.rc.

Running the latest dockerfile with rTorrent 0.9.7.

edit: Just tested with another client running without Docker, on a Ubuntu 18.04 host with rTorrent 0.9.6, the error still happens.

Response header contains: {"errno":"ECONNRESET","code":"ECONNRESET","syscall":"write"}

After that large torrent has failed to add, flood needs to be restarted to work again.

Carryozor commented 5 years ago

This issue is still up. Having the exact same problem as @bootldrDNB. @jfurrow my flood is update to date could you find any clue how to solve it (i tryed changing the network.xmlrpc.size_limit.set value and even my apache config but nothing work.

richardpickett commented 4 years ago

I'm also having this problem. When I first setup flood the above fix worked. I set the size limit to 20M and it all worked fine. Now I have 1M and 2M torrent files that I can't add via flood.

The only workaround for me was creating a watch dir for rtorrent and copying the files.

I haven't found a way to debug flood <-> rtorrent other than running flood from cmdline, but then I just see the POST get a 500, so no help there.

jesec commented 3 years ago

Flood 4.x adds torrents to rTorrent by local file path, which should resolve this issue.

Please try the latest version. Feel free to close the issue if it is no longer relevant.