search

Flood-UI / flood

A web UI for rTorrent, qBittorrent and Transmission with a Node.js backend and React frontend. Migrate to v4: https://github.com/jesec/flood/wiki/Migrate-from-older-versions-of-Flood.
https://flood.js.org
GNU General Public License v3.0
1.81k stars 174 forks source link

Travis coverage for Dockerfile #592

Open deed02392 opened 6 years ago

deed02392 commented 6 years ago

Just a suggestion - should we implement Travis CI coverage for the Dockerfile from this repo? We can verify that changes don't affect the Docker building and functionality. I have not got a lot of experience with Travis beyond having it do a build, but I believe it is possible to also test the functionality of the container too.

noraj commented 6 years ago

I agree but Travis is a solution, what we need is a CI for the Dockerfile, maybe in this case another CI will do a better Job.

deed02392 commented 6 years ago

We could just add test scripts to the existing .travis.yml.

Something like:

install:
  - docker build -t flood .
  - docker start -d -p 127.0.0.1:80:80 --name flood flood
script:
  - docker ps | grep -q flood
frebib commented 6 years ago

I'd like to add that the tests above should test that the web interface loads, possibly with curl? Also the port of the container need not be exposed, but instead the ip of the container used instead to communicate with it directly

noraj commented 6 years ago

@frebib Good idea, build a .travis.yml file and commit it to a test branch ;)

frebib commented 6 years ago

I can't say I've ever used Travis, but sure. When I get 5 minutes after my exams are done I'll give it a try