Add role attribute to clickable elements - Githubissues

Flood-UI / flood

A web UI for rTorrent, qBittorrent and Transmission with a Node.js backend and React frontend. Migrate to v4: https://github.com/jesec/flood/wiki/Migrate-from-older-versions-of-Flood.

https://flood.js.org

GNU General Public License v3.0

1.81k stars 173 forks source link

Add role attribute to clickable elements #886

Closed trailofdead closed 3 years ago

trailofdead commented 4 years ago

Add button role to SidebarFilter
Add button role to Tooltip li

Description

Adds role="button" to clickable li elements in SidebarFilter and div elements in Tooltip

Related Issue

https://github.com/Flood-UI/flood/issues/885

Motivation and Context

Add support for vimium keyboard navigation and screen readers

How Has This Been Tested?

Manual tested

Screenshots (if appropriate):

tooltip sidebar

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

jesec commented 3 years ago

If the PR is still relevant, rebase against new versions of Flood.

trailofdead commented 3 years ago

I'm going to open a PR on the other repo.