Floofies / NovaSector

The Blue Moon Branch is an enhanced fork of Nova Sector. This repository contains development branches for contributing to The Blue Moon Branch and NovaSector.
https://ko-fi.com/bluemoonclub
GNU Affero General Public License v3.0
3 stars 10 forks source link

Re-adds in Assault Ops and Black Mesa Modules #12

Open RS-Chan opened 3 months ago

RS-Chan commented 3 months ago

About The Pull Request

Re-adds in the Assault Ops and Black Mesa Modules for the upcoming sector gameplay. Reverts the remove changes done back on Main Nova Branch in early January-Feberury 2024. Following modules will be placed in modular_nova\modules

How This Contributes To The BlueMoon Roleplay Experience

Allows further gameplay elements for the upcoming sector where weapons are the main play.

Proof of Testing

After running in a local server (Pending Changes to the code), confirmed that you are able to purchase Sol Drum Magazines after modifying the Cargo Supply Console Board to "Broad". For balancing issues, currently will keep the standard 60 rounds though can be configured later down the line.

Screenshots/Videos

Changelog

:cl: add: Re-adds Assault Ops and Black Mesa Modules code: Re-enables Qarad Drum Magazine for purchase when supply console board is in "Broad" mode /:cl:

Floofies commented 3 months ago

I would like to fix two issues:

  1. Renaming certain people, places, and things to mitigate plagiarism of Microsoft and Sierra Studios intellectual property.

  2. I need to verify if the sound effects are licensed correctly and if we're honoring the license. I will explain this one.

I assume the sound effects are directly copied from Black Mesa by Crowbar Collective, which does have some CC BY-NC licensed sound effects in it, but I don't think I see the required things we need to abide by the license terms.

According to the legally binding terms for the CC BY-NC license:

You must give appropriate credit, provide a link to the license, and indicate if changes were made. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your use.

RS-Chan commented 3 months ago

Gotcha, I'll have to take a look into it further then before doing anymore changes/readding in and fulfill the legal requirements.

I would like to fix two issues:

1. Renaming certain people, places, and things to mitigate plagiarism of Microsoft and Sierra Studios intellectual property.

2. I need to verify if the sound effects are licensed correctly and if we're honoring the license. I will explain this one.

I assume the sound effects are directly copied from Black Mesa by Crowbar Collective, which does have some CC BY-NC licensed sound effects in it, but I don't think I see the required things we need to abide by the license terms.

According to the legally binding terms for the CC BY-NC license:

You must give appropriate credit, provide a link to the license, and indicate if changes were made. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your use.

RS-Chan commented 2 months ago

About The Pull Request

Re-adds in the Assault Ops and Black Mesa Modules for the upcoming sector gameplay. Reverts the remove changes done back on Main Nova Branch in early January-Feberury 2024. Following modules will be placed in modular_nova\modules

How This Contributes To The BlueMoon Roleplay Experience

Allows further gameplay elements for the upcoming sector where weapons are the main play.

Proof of Testing

After running in a local server (Pending Changes to the code), confirmed that you are able to purchase Sol Drum Magazines after modifying the Cargo Supply Console Board to "Broad". For balancing issues, currently will keep the standard 60 rounds though can be configured later down the line. Screenshots/Videos

Changelog

🆑 add: Re-adds Assault Ops and Black Mesa Modules code: Re-enables Qarad Drum Magazine for purchase when supply console board is in "Broad" mode /:cl:

Forgot to reference Novasector main where it got removed, here it is

https://github.com/NovaSector/NovaSector/pull/282/files#diff-e95bbeed7815b1697ece053cae092d2b790844338ccedd0ec9d166aa7726c67d