search

Floogen / DynamicReflections

Stardew Valley framework which enables water and mirror reflections within Stardew Valley.
GNU General Public License v3.0
8 stars 7 forks source link

[Bug] Discoloration of water in desert/island #27

Closed NightFright2k19 closed 2 years ago

NightFright2k19 commented 2 years ago

At least in fall season (playing that now), water on the farm and on Ginger Island is purple and the lake in the desert is black. This might be due to a combination with some other mod I have installed which still needs to be investigated. purple_farm black_desert purple_island

NightFright2k19 commented 2 years ago

Update: Seems it has to do something with NPC reflections. If I turn them off in the default settings, water color becomes normal - however only as long as the player character does not approach the water. If it gets closer, as soon as a reflection is supposed to be drawn (or before it's about to), water color switches again - returning back to normal as soon as you back off and so on, like a switch.

Sky reflections or wavy animations don't seem to have any impact. Basically it's impossible to get a reflection with a normally colored water surface, at least in the areas I mentioned.

Floogen commented 2 years ago

Have you been able to replicate this with just SMAPI + Dynamic Reflections? Thus far I have not been able to.

NightFright2k19 commented 2 years ago

I just tested it with this minimal configuration:

The problem still exists like that, even with all the other mods that I am normally using out of the way. I don't think that providing my config file helps much since I pretty much use the default settings, besides also using wavy reflections. Anyway, I tried deleting the config file and let the game generate a new one, same thing.

The issue disappears partially when deactivating NPC relections (behavior as described above, discoloration as soon as you approach water) and completely when turning off water reflections in general.

Maybe it also depends on a game setting, but tbh I wouldn't be able to guess which one it could be right now. My graphics settings are like this:

Floogen commented 2 years ago

I have pinpointed the issue. My default testing suite was using SMAPI + Dynamic Reflections + Visible Fish. When removing the latter, I can replicate your issue.

It seems to be tied to my compatibility patch for Visible Fish, so I'll need to investigate further. Thank you for the help in pinpointing this issue.

NightFright2k19 commented 2 years ago

Excellent! Fingers crossed it can be solved soon since this is a quite annoying glitch.

Floogen commented 2 years ago

This should be fixed with v1.3.4!