Closed Adda0 closed 8 months ago
Adding multiple mods already exists as a feature via drag-and-dropping multiple mod archives, so I am unsure if I want to merge this due to feature overlap.
If drag-and-drop is not available (I assume it is not with the Steam Deck), I think a simpler solution would be to enable multiple archive selection to the File > Add Mod
command.
Furthermore, each click on any checkbox in mod list takes several seconds, shifts the mod list view (when the mod list refreshes). For Stardrop to be usable for such quantity of mods, updating after every checkbox click is undesirable.
I am not able to replicate this issue, but that is likely due to a hardware difference. I do like the idea of not automatically updating the profile until SMAPI is started / via Save Profile button / before Stardrop is closed.
Adding multiple mods already exists as a feature via drag-and-dropping multiple mod archives, so I am unsure if I want to merge this due to feature overlap.
I can understand your reasoning. I can therefore keep this feature as a feature specific to my fork, as I really enjoy the simplicity of its workflow and do not want to lose the option. It is a pretty isolated feature which should not get in the way too much when working on other changes, I hope.
I think a simpler solution would be to enable multiple archive selection to the File > Add Mod command.
As far as I know, that should be as easy as setting the file picker call to allow selection of multiple files. The infrastructure to support the multi-selection should be already in place.
I can refactor the PR to:
File -> Add Mod
file picker.Alternatively, I can further split the PR into:
Enable
check box is clicked.File -> Add Mod
.How do you feel about this approach?
The second approach works best, as I always prefer to have separate pull requests for different features.
Thank you for your efforts!
Closed due to splitting the PR into multiple smaller PRs and refactoring, as per https://github.com/Floogen/Stardrop/pull/146#issuecomment-1872370829.
This PR adds a convenience function to add (+ update) multiple mods at once by just clicking one button. It allows for specifying one folder where to find mods (the folder is searched for archive files).
I find this workflow very pleasant to use:
Update available
notifications to open mod websites.I have 3k mods installed. Each refresh of mod list or update of profiles takes several seconds. Therefore, it is crucial that each install of a new mod doe not refresh the mod list or update the profile. Refresh is performed only after all bulk-installed mods are installed.
Furthermore, each click on any checkbox in mod list takes several seconds, shifts the mod list view (when the mod list refreshes). For Stardrop to be usable for such quantity of mods, updating after every checkbox click is undesirable. I added a button to save changes which updates the profile, refreshes the mod list, etc. It is also automatically run when starting SMAPI, as it already was previously. For this reason, when a user clicks the checkbox, nothing happens until they click either run SMAPI, save changes, or click one of the menu save/update something options. If this is an undesirable design approach in your eyes, a settings option "Save changes manually" with tooltip description "Do not save changes until changes are confirmed." or something similar can be added, too.
If you find this feature interesting, translations (for now just copy-paste the English description, I presume) for other languages need to be added. Tested on Linux, not tested on Windows and MacOS.