search

Floogen / Stardrop

Stardrop is an open-source, cross-platform mod manager for the game Stardew Valley.
https://floogen.gitbook.io/stardrop/
GNU General Public License v3.0
114 stars 31 forks source link

Set correct mod install path #155

Closed Adda0 closed 8 months ago

Adda0 commented 8 months ago

This PR fixes setting manifest path during installation/update of mods so that Mod.Path for the mod can be correctly computed. Without setting the path properly, no mod can be added/updated.

I am not sure how it happened, but apparently I forgot to include this commit in the previous PRs due to the refactorization of #146, and since the PRs were separated by features, adding mods with mod grouping mode was never tested in the upstream version, it seems.

Tested on Linux, not tested on Windows or MacOS.

Floogen commented 8 months ago

This was already changed in #148, which is awaiting feedback.

You can see the change here.

Adda0 commented 8 months ago

Aha. So I just included the commit in a wrong PR. It should have come with the initial grouping PR. Then feel free to either merge this PR or wait for #148 and close this one. The important thing is that it will get merged eventually.

Floogen commented 8 months ago

I will close this one in the interim.