search

Floogen / Stardrop

Stardrop is an open-source, cross-platform mod manager for the game Stardew Valley.
https://floogen.gitbook.io/stardrop/
GNU General Public License v3.0
110 stars 30 forks source link

Adjust Settings window so that content expands as it resizes #193

Closed pingzing closed 2 months ago

pingzing commented 2 months ago

Minor fix, unrelated to my other PR. Allows the Settings window's content to expand vertically, along with the window.

Before After
before after

Note: the Height set in SettingsWindow.axaml gets ignored because SizeToContent is set to SizeToContent.Height. If we want the window to open up to the height of 500 as set, we'll need to remove that from the constructor.

Floogen commented 2 months ago

This is great! Thank you for getting that menu fixed up.

I made a minor adjustment to have the height of SettingsWindow based on the parent window and removed the SizeToContent.Height restriction.

If that change looks good to you, I will merge it over.

pingzing commented 2 months ago

I'd just pass in the desired height rather than the whole Window. Separation of concerns and all that. But otherwise, looks fine 👍

EDIT: oh, dang and you might want to remove the explicit Height in the XAML file too. Otherwise in three months you'll be like "...why am I setting the height twice?"

Floogen commented 2 months ago

Good idea on both points! I have added those changes and merged it over.

Thank you for the pull request!