search

FloorDAO / floor-v2

Floor aims to create a fully onchain governance mechanism for sweeping and deploying NFTs to profitable NFT-Fi strategies as well as seeding liquidity for its own NFT-Fi products.
https://floor.xyz
2 stars 0 forks source link

Prevent Manual Sweeper from receiving ETH #37

Closed tomwade closed 1 year ago

tomwade commented 1 year ago

Adds Manual Sweeper execution requirements to prevent ETH and no message, supplemented with a test suite for various approaches.

tomwade commented 1 year ago

From review, I agree. The Manual Sweeper should not hold any ETH allocation, but instead of preventing the transaction from running, we need to ensure that the manual sweeper can correctly respond with the message during the expected flow. So really it should be used in this flow.

Sweep registered -> OTC purchase made outside of chain -> Sweep registered using Manual Sweeper

So there should be no ETH allocation, but the sweep should still be registered with a string message, likely relating to the OTC transaction address.