search

FloorDAO / floor-v2

Floor aims to create a fully onchain governance mechanism for sweeping and deploying NFTs to profitable NFT-Fi strategies as well as seeding liquidity for its own NFT-Fi products.
https://floor.xyz
2 stars 0 forks source link

Add liquidation epoch trigger to deployment #53

Closed tomwade closed 1 year ago

tomwade commented 1 year ago

In deployment we don't add an epoch trigger for the liquidation contract, I think you might want one but it can always be added later.

https://github.com/FloorDAO/floor-v2/blob/06d4d01b470136c7b905ffe8624c4f964a89e7df/script/deployment/111_DeployEpochTriggers.s.sol#L33

tomwade commented 1 year ago

For this epoch trigger to be added, we will have needed to have deployed a DistributedRevenueStakingStrategy strategy.

I have updated the deployment script to deploy an instance of this strategy via the StrategyFactory before deploying the trigger.

        LiquidateNegativeCollectionTrigger liquidateNegativeCollection = new LiquidateNegativeCollectionTrigger(
            sweepWars,
            strategyFactory,
            DEPLOYED_CREATED_STRATEGY_ADDRESS,
            0x3fC91A3afd70395Cd496C647d5a6CC9D4B2b7FAD
        );

One decision that will need to be made (cc @0xCaps) is that we will need to define a max "per-epoch release amount". This will determine the amount of liquidated assets that are released into the sweep each epoch. I currently have this set as 10 ETH as this would support our minimum sweep amount. This amount is immutable.

tomwade commented 1 year ago

PR has been added here: https://github.com/FloorDAO/floor-v2/pull/59

0xCaps commented 1 year ago

I currently have this set as 10 ETH as this would support our minimum sweep amount. This amount is immutable.

Can we please make this mutable? It will likely need to change as the treasury scales.