Closed tomwade closed 1 year ago
From reviewing this issue, I'm not happy with the multicall
implementation. I am going to delete it in this PR and then research and implement a new version if required.
Test coverage has now been updated on branch. I'll regenerate the coverage in the morning and will compare the output.
Following a
forge coverage
call, I've seen a number of small areas that will need some more test coverage. I've made the following notes against the generated report:Notes
UniswapV3Strategy.sol
generates a "Stack Too Deep" error, due to thepositions()
function returning too many variables when the call is not optimised.DeploymentScript.sol
file, I don't think we need anyforks
folder, as it is directly copied from fully audited codebasestests
folder, as these are mostly mocks or utilitiesActions
actions/llamapay/Withdraw.sol
has no testsEpochManager.sol
is missing some function testsactions/Action.sol
has no testsactions/nftx/BuyNftsWithEth.sol
has no testsactions/utils/Multicall.sol
has no testsactions/utils/RawTx.sol
has no tests