FloorDAO / floor-v2

Floor aims to create a fully onchain governance mechanism for sweeping and deploying NFTs to profitable NFT-Fi strategies as well as seeding liquidity for its own NFT-Fi products.
https://floor.xyz
2 stars 0 forks source link

Additional test coverage #67

Closed tomwade closed 1 year ago

tomwade commented 1 year ago

This discovered an issue in the epoch timestamp calculation in src/contracts/EpochManager.sol and the ETH refund logic in src/contracts/actions/nftx/BuyNftsWithEth.sol.

I made some updates to a number of actions as well that made them run more efficiently when test suites started calling edge cases.

I also deleted the Multicall contract as it wasn't working correctly. I don't think that making small changes and tweaks would make it effective, so I've deleted to take it back to the drawing board.

Test coverage is now much better:

Screenshot 2023-08-23 at 09 06 05