search

FloorDAO / floor-v2

Floor aims to create a fully onchain governance mechanism for sweeping and deploying NFTs to profitable NFT-Fi strategies as well as seeding liquidity for its own NFT-Fi products.
https://floor.xyz
2 stars 0 forks source link

[NFX-02M] Incorrect Event Argument #99

Closed tomwade closed 1 year ago

tomwade commented 1 year ago

NFX-02M: Incorrect Event Argument

Type Severity Location
Language Specific NFTXLiquidityPoolStakingStrategy.sol:L217

Description:

The Withdraw event is expected to emit the recipient of the withdrawal as its third argument, however, the msg.sender is specified instead.

Example:

emit Withdraw(underlyingToken, amount_, msg.sender);

Recommendation:

We advise the code to properly emit the recipient value as the last argument of the Withdraw event, ensuring off-chain processes properly track and credit the withdrawal events.