search

Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
5.8k stars 161 forks source link

[Bug]: Linux PWA doesn't retain its PWA icon after loading, and reverts back the Floorp icon, and gets grouped with it. #1102

Open 32bitx64bit opened 6 months ago

32bitx64bit commented 6 months ago

Pre-Submission Checklist

Bug Summary

When you open a PWA via the taskbar / any other way (This example im on KDE), it will retain its icon until the webpage is fully loaded, then it reverts back to the Floorp icon, and gets grouped with it again.

Here's a video of it happening to better explain

https://github.com/Floorp-Projects/Floorp/assets/86190528/79fad40a-ffeb-4694-942f-6a07b202d406

Reproduction Steps

Install any PWA on Linux KDE.

Open PWA

Done.

Expected Behavior

Expected behavior should be like on windows where it retains its identity.

Actual Behavior

https://github.com/Floorp-Projects/Floorp/assets/86190528/66b4f5f2-7ee3-4c74-9258-3389cd732e11

Screenshots

https://github.com/Floorp-Projects/Floorp/assets/86190528/8b21f027-0ada-4987-bfe8-422e856c52ae

Browser Version

11.12.0

Operating System

Arch Linux KDE Plasma 6.0.3

Additional Context

No response

Sasikuttan2163 commented 6 months ago

Unfortunately that's a limitation of how the PWA was implemented. For this release we focused only on creating a desktop entry so that the app gets listed on launchers. I'm currently looking into it.

32bitx64bit commented 6 months ago

Unfortunately that's a limitation of how the PWA was implemented. For this release we focused only on creating a desktop entry so that the app gets listed on launchers. I'm currently looking into it.

Ah. Hopefully this gets resolved! But it is nice to see linux PWA's being worked on.

b-risk commented 5 months ago

Apologizes for (semi) unrelated question, but how would I go about adding a shortcut like this to a web app in Linux Mint? I've created web apps in Floorp I didn't see an option to add a shortcut for it in Floorp settings.

Sasikuttan2163 commented 5 months ago

Can you be more specific as to what you mean by create a shortcut? Is it that the app doesn't appear in the all apps list or you can't create a shortcut to the app in the desktop? (Sorry for the late reply, I have exams going on)

b-risk commented 5 months ago

Can you be more specific as to what you mean by create a shortcut? Is it that the app doesn't appear in the all apps list or you can't create a shortcut to the app in the desktop? (Sorry for the late reply, I have exams going on)

Yes I should have clarified, I meant like how there isn't shortcuts on Linux but they use launchers instead that appear in the apps list, I don't see an option anywhere to create one of these for my Floorp web apps on my distro, also I should mention I'm using the cinnamon desktop version of Linux Mint.

RimPYExposing commented 5 months ago

Can you be more specific as to what you mean by create a shortcut? Is it that the app doesn't appear in the all apps list or you can't create a shortcut to the app in the desktop? (Sorry for the late reply, I have exams going on)

Yes I should have clarified, I meant like how there isn't shortcuts on Linux but they use launchers instead that appear in the apps list, I don't see an option anywhere to create one of these for my Floorp web apps on my distro, also I should mention I'm using the cinnamon desktop version of Linux Mint.

As stated on the PWA, this is experimental, if theirs a bug unrelated to this, create a new issue instead of clogging this one up with unrelated questions. As this currently works fine on KDE plasma 6 (wayland)

Jeremi360 commented 5 months ago

@Sasikuttan2163 What @b-risk means is that linux mint has it own app called Webapp-Manger that allows to crate desktop web app using any of many supported browsers, but floorp is not supported, but it is not a real PWA - they hack normal way of opening normal websites.

I some how their way of doing this dosen't have such problems. Also I like that floorp in current version allow me to use even discord as web app, even though it is not a PWA

Sasikuttan2163 commented 5 months ago

@Sasikuttan2163 What @b-risk means is that linux mint has it own app called Webapp-Manger that allows to crate desktop web app using any of many supported browsers, but floorp is not supported, but it is not a real PWA - they hack normal way of opening normal websites.

I some how their way of doing this dosen't have such problems. Also I like that floorp in current version allow me to use even discord as web app, even though it is not a PWA

Oh that's pretty neat! Yeah as you said Floorp uses its own implementation for making PWAs so it doesn't need another launcher made by Webapp-Manager. Thanks for pointing this out @Jeremi360 and hope this answer is satisfactory @b-risk. As long as your web apps show up in the applications list, all is well.

b-risk commented 5 months ago

@Sasikuttan2163 What @b-risk means is that linux mint has it own app called Webapp-Manger that allows to crate desktop web app using any of many supported browsers, but floorp is not supported, but it is not a real PWA - they hack normal way of opening normal websites.

I some how their way of doing this dosen't have such problems. Also I like that floorp in current version allow me to use even discord as web app, even though it is not a PWA

Yes I know Floorp has a different implementation and that's why I didn't mention that app, I'm just confused on how to create one of these app launchers that show in the apps list for Floorp web apps, like how on KDE how do you create them? To be clear, I have several web apps already in Floorp created, they just don't show in the apps list, that's the reason I didn't post this as an issue because I was confused if it was intended behavior or if it's actually a distro specific issue and it's supposed to add automatically to my apps list. Thanks and apologies again.

Sasikuttan2163 commented 5 months ago

Yes I know Floorp has a different implementation and that's why I didn't mention that app, I'm just confused on how to create one of these app launchers that show in the apps list for Floorp web apps, like how on KDE how do you create them? To be clear, I have several web apps already in Floorp created, they just don't show in the apps list, that's the reason I didn't post this as an issue because I was confused if it was intended behavior or if it's actually a distro specific issue and it's supposed to add automatically to my apps list. Thanks and apologies again.

Oh that's weird. Are you saying it doesn't show up in the app list at all? I just installed Cinnamon myself and found my Floorp web apps in the "Others" sub section within the launcher.

b-risk commented 5 months ago

Yes I know Floorp has a different implementation and that's why I didn't mention that app, I'm just confused on how to create one of these app launchers that show in the apps list for Floorp web apps, like how on KDE how do you create them? To be clear, I have several web apps already in Floorp created, they just don't show in the apps list, that's the reason I didn't post this as an issue because I was confused if it was intended behavior or if it's actually a distro specific issue and it's supposed to add automatically to my apps list. Thanks and apologies again.

Oh that's weird. Are you saying it doesn't show up in the app list at all? I just installed Cinnamon myself and found my Floorp web apps in the "Others" sub section within the launcher.

Ah, I wasn't sure so it's just automatic, I just tried it again and now it shows in the apps list, I was sure I had tried several times... maybe my flatpak had updated without me noticing? Anyways thanks for the help!

Sasikuttan2163 commented 5 months ago

Glad it got fixed! 😄