Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
4.97k stars 144 forks source link

[Bug]: Restarting Floorp moves some tabs to the wrong Workspace and Container #1192

Open tunaflsh opened 1 month ago

tunaflsh commented 1 month ago

Pre-Submission Checklist

Bug Summary

I have multiple windows, workspaces open. Some have separate containers. Sometimes when exiting (ctrl+shift+Q to close all windows) and starting Floorp again, some tabs move to other workspaces and even to the other container. This occurs only within a window, tabs don't move to other windows.

Reproduction Steps

  1. Turn on setting "Open previous windows and tabs"
  2. Open multiple Windows (ctrl+N)
  3. Create a few Workspaces in each Window, possibly with different Containers
  4. Populate Workspaces with different tabs
  5. Exit (ctrl+shift+Q)
  6. Start Floorp

Expected Behavior

Everything should look exactly like before exiting.

Actual Behavior

Some tabs are shuffled around workspaces within the same window.

Screenshots

Later

Browser Version

11.13.3 (64-bit)

Operating System

Windows 11

Additional Context

I don't have a video recording yet, since my current profile has private information.

I'll make a new profile and do more thorough tests, like checking if this still happens with one active window. And I will record a video demonstration. Please don't close this issue.

tunaflsh commented 1 month ago

Ok, this bug might be a combination of multiple bugs: #1129 and a bug that empty workspace steals a tab from another workspace. I'll still do a more thorough test as I promised. But this might take some time.

JosefLitos commented 1 month ago

I have a similar issue using Simple Tab Groups addon. It also allows for categorizing tabs into workspaces, hiding all other tabs from other than the current workspace/tab group. When I close and reopen floorp, one group always got all panels purged, the current last opened tab got replaced with a New Tab, one tab got always removed from a different group and containers that the tabs belong to changed from their original.

I cannot use Workspaces, because it lacks a key mapping for moving a tab to a workspace and choosing a workspace to switch to (instead of cycling through them all).