search

Floorp-Projects / Floorp

All of source code of version 10 or later of Floorp Browser, the most Advanced and Fastest Firefox derivative 🦊
https://floorp.app
Other
4.97k stars 144 forks source link

[FB] Preferences | Add "close window with last tab" preference #1211

Closed doxxx closed 4 days ago

doxxx commented 3 weeks ago

Check list

This adds the existing Firefox preference browser.tabs.closeWindowWithLastTab to the Floorp Preferences > General >Tabs section, as discussed here.

doxxx commented 3 weeks ago

I add the resource for English, but I don't know what the process is for adding translations.

CutterKnife commented 3 weeks ago

Is this what you're talking about? https://github.com/Floorp-Projects/Unified-l10n-central

doxxx commented 3 weeks ago

I mean that I added a resource to browser/locales/en-US/browser/preferences/preferences.ftl but the same resource appears in similar files for all the other languages. I don't know what the process is for getting those updated.

doxxx commented 1 week ago

Is there anything I need to do to help merge this PR?

TheChilledBuffalo commented 1 week ago

@doxxx Hey thanks for the PR! However, this might not be the right way to do it. We generally avoid making such changes in this repository. We keep it as close to the original Firefox code as possible. Most Floorp specific changes are made in the Floorp-core repository which has been added as a submodule to this repo.

https://github.com/Floorp-Projects/Floorp-core

So changes such as adding preferences, are made here. And for localisation and adding new strings, we use the repository that @CutterKnife posted above.

https://github.com/Floorp-Projects/Unified-l10n-central

I think the main dev would be ready to merge this if you split this up into two PRs, one each in the two repositories I mentioned.

doxxx commented 1 week ago

Thanks for the info. I'll take a look at resubmitting the changes to those repos.